Code review comment for lp://qastaging/~compiz-team/compiz/compiz.fix_1041535.1
Revision history for this message
| Sam Spilsbury (smspillaz) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
bbfa235
demo site
(Get the code!)
> I'm still terrified that we're considering a 7819 line diff right at the end
> of the cycle.
>
> Could you instead propose a tiny fix for bug 1041535 and let's discuss this
> one after branching?
I'd prefer not to - there's no difference in runtime risk betwene a 7.8k diff where 300 lines touch runtime code and are about fixing the bug and a 300 line diff where 300 lines are about fixing the bug and touch runtime code.
The only reason the diff is so large is because the test code itself has been shuffled around. Mostly to get it into separate libraries.