Wow, this is much bigger than it really should be, by a factor of a least 10.
Initial thoughts:
1. Indenting for four levels of namespace is a bit crazy. If you really need four then please merge all of these into a single line:
namespace compiz { namespace opengl { namespace fb { namespace impl {
2. FramebufferDirectDraw is not a helpful name for a class. That seems to tell me what it does (verb), not what it is (noun). Please try to think of a better name.
« Back to merge proposal
Wow, this is much bigger than it really should be, by a factor of a least 10.
Initial thoughts:
1. Indenting for four levels of namespace is a bit crazy. If you really need four then please merge all of these into a single line:
namespace compiz
namespace impl
{
namespace opengl
{
namespace fb
{
{
2. FramebufferDire ctDraw is not a helpful name for a class. That seems to tell me what it does (verb), not what it is (noun). Please try to think of a better name.