Code review comment for lp://qastaging/~compiz-team/compiz/compiz.performance_1040478

> Wow, this is much bigger than it really should be, by a factor of a least 10.
>
> Initial thoughts:
>
> 1. Indenting for four levels of namespace is a bit crazy. If you really need
> four then please merge all of these into a single line:
>
> namespace compiz
> {
> namespace opengl
> {
> namespace fb
> {
> namespace impl
> {
>

We can probably remove the "fb" namespace.

My understanding is that compiz::plugin and compiz::plugin::impl was more or less the convention now.

> 2. FramebufferDirectDraw is not a helpful name for a class. That seems to tell
> me what it does (verb), not what it is (noun). Please try to think of a better
> name.

Possible alternatives:

 * RectangleFramebufferPainter
 * DirectFramebufferPainter (yes, I know these are er's)

I don't think its possible to give this class a noun-name as it describes a process. Maybe it could exist better as a function?

I've tested it on nvidia, nouveau and intel.