Code review comment for lp://qastaging/~compiz-team/compiz/compiz.performance_1040478

On Wed, 12 Sep 2012, Daniel van Vugt wrote:

> * "Platform" is a redundant word and possibly poorly chosen. Not sure. All the code is for one platform or another...
>

Well, the "platform" in this case is either EGL or GLX. What would you
call it?

> * priv->mMyMemberName is an over-complication. It's obviously a member by virtual of being on the right hand side of "priv->". So they should probably just be priv->myMemberName.
>

Likely, I can change that.

> * Please fit your code into 80 columns. If it doesn't fit then that's a good sign that it needs fixing.
>

Clean Code suggests 120 columns for C++. Its not feasible to stick to the
80 line rule for C++ where namespaces are in use and you have descriptive
function names.

Any ideas on what to call the FramebufferDirectDraw class? Or should we
change both that and PlatformFramebuffer to be boost::function objects?

>
> --
> https://code.launchpad.net/~compiz-team/compiz/compiz.performance_1040478/+merge/123798
> Your team Compiz Maintainers is subscribed to branch lp:compiz.
>