Code review comment for lp://qastaging/~corey.bryant/charms/trusty/keystone/action-managed-upgrade

When I ran the upgrade action, I required a subsequent config-changed manual hook run in order to get the upgrade to work properly. The initial run of the openstack-ugprade action did upgrade all of the necessary packages, however the template rendering engine rendered kilo, then rendered icehouse templates (from which I was ugprading from). Digging into this a bit, I suspect its due to the way that the charmhelpers.contrib.openstack.utils.get_os_codename_package works. Since this is determined as part of register_configs(), which happens prior to the upgrade, the package versions are kept at the icehouse level which causes the icehouse templates to be rendered. I noticed this because I experienced bug https://bugs.launchpad.net/charms/+source/keystone/+bug/1417211 upon upgrade, then realized that this is due to rendering the icehouse template as can be seen at http://paste.ubuntu.com/12517976/.