Code review comment for lp://qastaging/~coreygoldberg/selenium-simple-test/native-to-synthesized
Revision history for this message
| Javier Collado (javier.collado) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
f399f05
demo site
(Get the code!)
What I meant is that it seems risky to change defaults and force all test cases to use synthesized events because it might fix problems for some test cases and break other ones.
I guess that the decision to make here is what is going to take less work:
- update test cases with problems one by one to use synthesized events
- change the default and fix the test cases that break, if any, because of the change
If you're pretty sure that the way to go is change the default, then go for it, just take into account what are the risks.
Also note that it might happen that someone else is using SST and this change breaks his test cases. A good practice to prevent that from happening would be to have an intermediate release that prints a warning message to let the user know that the defaults are going to change in the future.