Code review comment for lp://qastaging/~csurbhi/mdadm/mdadm-fix.728435

Thanks for your contribution to Ubuntu!

I've updated lp:~ubuntu-core-dev/mdadm/ubuntu to match the current archive. Please could you merge from that branch, resolve any changelog conflicts, and then re-push to lp:~csurbhi/mdadm/mdadm-fix.728435? (You don't need to file a new merge proposal - this one will update automatically.)

Secondly, patch files in debian/patches/ should only be used when patching upstream source code. When changing files in debian/, you should just change them directly rather than with a patch file. In this case, you should just be able to undo your changes to debian/patches/, since your branch already changes debian/initramfs/init-premount as well.

Finally, there are some confusing typos in the changelog - according to mdadm(8), -r is short for --remove while -R is short for --run. As such, I think the two mentions of -Ars should be corrected to -ARs, while the mention of -Irs should be corrected to -IRs.