Code review comment for lp://qastaging/~csurbhi/ubuntu/natty/plymouth/plymouth.bug-fix566818
Revision history for this message
| Surbhi Palande (csurbhi) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
bbfa235
demo site
(Get the code!)
Following are some details of the patch:
1) The patch prints the entire prompt the first time (i.e when number of bullets to be printed is zero). It prints only the last line when the user presses a key (i.e bullets > 0)
2) The patch removes the independent printing of ':' as this is included in the prompt. No other plugin prints the ':' separately. So it makes sense to remove it from here and add it to the default prompt or expect it in the user defined prompt (just like in other plugins)