Code review comment for lp://qastaging/~csurbhi/ubuntu/natty/plymouth/plymouth.bug-fix566818

Revision history for this message
Steve Langasek (vorlon) wrote :

@@ -363,16 +384,16 @@
                     strlen (CLEAR_LINE_SEQUENCE));
   plugin->state = PLY_BOOT_SPLASH_DISPLAY_PASSWORD_ENTRY;

- if (prompt)
+ if (prompt) {
+ shorten_prompt(&prompt);
     write_on_views (plugin,
                     prompt,
                     strlen (prompt));
+ }
   else

This seems to drop the special handling of the bullets == 0 case. Sorry if my comments were unclear, I do believe that we still need to handle that case specially. Testing with the patch as-is, I never see the first line of the cryptsetup prompt.

review: Needs Fixing

« Back to merge proposal