Code review comment for lp://qastaging/~cyphermox/libindicator/inline

Revision history for this message
Didier Roche-Tolomelli (didrocks) wrote :

hey,

670 --- debian/compat 1970-01-01 00:00:00 +0000
671 +++ debian/compat 2012-11-21 20:23:25 +0000
672 @@ -0,0 +1,1 @@
673 +5

-> hum, I guess it needs to be 9

698 +Vcs-Bzr: https://code.launchpad.net/~ubuntu-desktop/libindicator/ubuntu
699 +Vcs-Browser: http://bazaar.launchpad.net/~ubuntu-desktop/libindicator/ubuntu
-> I think it needs to be changed to the real upstream URL + add the warning (see my comment yesterday on another MR)

879 +override_dh_makeshlibs:
880 + dh_makeshlibs -plibindicator7 -V 'libindicator7 (>= 0.4.90)'
881 + dh_makeshlibs -plibindicator3-7 -V 'libindicator3-7 (>= 0.4.90)'
882 +
and adding DPKG_GENSYMBOLS_CHECK_LEVEL=4
Not for this merge, but I think we should add a symbols file for the library rather than using a shlibs, wdyt? Can you add that to your list?

Please fix the 2 first steps and I'll approve. Thanks. (builds fine in pbuilder)

review: Needs Fixing

« Back to merge proposal