Code review comment for lp://qastaging/~daker/webbrowser-app/fix.1317428

Revision history for this message
Olivier Tilloy (osomon) wrote :

If we really want to be strict about URL validation, I think we shouldn’t reinvent the wheel. QUrl provides us everything we need to parse a URL from a string and check whether it’s valid. Unfortunately it’s not exposed to QML (the url type in QML doesn’t match our needs), so we’d need to expose a C++ helper to QML to validate a given URL.

« Back to merge proposal