Code review comment for lp://qastaging/~dandrader/qtmir/keyState

Revision history for this message
Gerry Boland (gerboland) wrote :

How about using the anonymous namespace we have? I can stick this in there

static qint64 msecsSinceReference()
{
    static QElapsedTimer elapsedTimer;
    elapsedTimer.start();
    return elapsedTimer.msecsSinceReference();
}

and it works ok. After all it is just a function to return a timestamp, which is a purely internal implementation thing that doesn't need to be a class member IMO.

+ if (m_focused) {
   releaseAllPressedKeys();
Why not on unfocus?

« Back to merge proposal