Merge into trunk : availableDesktopArea : Code : Unity 8

Status:	Superseded
Proposed branch:	lp://qastaging/~dandrader/unity8/availableDesktopArea
Merge into:	lp://qastaging/unity8
Diff against target:	861 lines (+342/-61) 15 files modified debian/control (+3/-3) plugins/WindowManager/AvailableDesktopArea.cpp (+50/-0) plugins/WindowManager/AvailableDesktopArea.h (+38/-0) plugins/WindowManager/CMakeLists.txt (+7/-0) plugins/WindowManager/WindowManagerPlugin.cpp (+5/-1) plugins/WindowManager/WindowMargins.cpp (+74/-0) plugins/WindowManager/WindowMargins.h (+59/-0) qml/Shell.qml (+8/-1) qml/Stage/ChildWindow.qml (+8/-1) qml/Stage/ChildWindowTree.qml (+2/-1) qml/Stage/DecoratedWindow.qml (+14/-7) qml/Stage/Stage.qml (+57/-47) tests/qmltests/Stage/tst_DesktopStage.qml (+7/-0) tests/qmltests/Stage/tst_PhoneStage.qml (+5/-0) tests/qmltests/Stage/tst_TabletStage.qml (+5/-0)
To merge this branch:	bzr merge lp://qastaging/~dandrader/unity8/availableDesktopArea
Related bugs:	Link a bug report

Reviewer	Review Type	Date Requested	Status
Albert Astals Cid (community)			Needs Fixing on 2017-03-13
Unity8 CI Bot	continuous-integration		Approve on 2017-03-07
Michael Zanetti (community)		2017-03-03	Approve on 2017-03-07
Review via email: mp+318878@code.qastaging.launchpad.net

Revision history for this message

Unity8 CI Bot (unity8-ci-bot) wrote on 2017-03-03:

#

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/3270/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

Michael Zanetti (mzanetti) wrote on 2017-03-03:

#

reading the code it looks good I'd say. One question though:

In Stage.qml we have that boundariesForWindowPlacement Item which seems to do the same. Is this the begin of a transition away from that and we're ok with having both things active for the time being or should we rather get rid of that too in here?

review: Needs Information

Revision history for this message

Daniel d'Andrada (dandrader) wrote on 2017-03-03:

#

On 03/03/2017 07:34, Michael Zanetti wrote:
> Review: Needs Information
>
> reading the code it looks good I'd say. One question though:
>
> In Stage.qml we have that boundariesForWindowPlacement Item which seems to do the same. Is this the begin of a transition away from that and we're ok with having both things active for the time being or should we rather get rid of that too in here?

Good point. I forgot about boundariesForWindowPlacement. Will try to
merge the two.

Revision history for this message

Unity8 CI Bot (unity8-ci-bot) wrote on 2017-03-03:

#

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/3273/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

Michael Zanetti (mzanetti) wrote on 2017-03-03:

#

I'm wondering why we still need those restrictions in Stage.qml at all, like the minimumY for WindowStateSaver, or the boundsItem on the MoveResizeArea. I would think now that miral knows the limits the qml code should not need to care about this any more at all? Perhaps miral is not quite there yet, I'm not sure. If we still need to provide those informations to the qml code, wouldn't it make sense to at least drop root.leftMargin etc and use the availableDesktopArea item instead now?

review: Needs Information

Revision history for this message

Daniel d'Andrada (dandrader) wrote on 2017-03-03:

#

On 03/03/2017 08:42, Michael Zanetti wrote:
> Review: Needs Information
>
> I'm wondering why we still need those restrictions in Stage.qml at all, like the minimumY for WindowStateSaver, or the boundsItem on the MoveResizeArea. I would think now that miral knows the limits the qml code should not need to care about this any more at all?

Yeah, miral/qtmir might take care of it in the future. But they don't do
it right now.

> Perhaps miral is not quite there yet, I'm not sure.

It's not AFAICT.

> If we still need to provide those informations to the qml code, wouldn't it make sense to at least drop root.leftMargin etc and use the availableDesktopArea item instead now?

Done. Also replaced usage of Panel.panelHeight with AvailableDesktopArea.

Revision history for this message

Unity8 CI Bot (unity8-ci-bot) wrote on 2017-03-03:

#

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/3277/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

Unity8 CI Bot (unity8-ci-bot) wrote on 2017-03-03:

#

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/3278/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

Michael Zanetti (mzanetti) wrote on 2017-03-07:

#

Code looks good now, tested it, works fine.

I've added ppa:ci-train-ppa-service/2544 to the description and kicked a CI build. lets see...

review: Approve

Revision history for this message

Unity8 CI Bot (unity8-ci-bot) wrote on 2017-03-07:

#

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/3296/rebuild

PASSED: Continuous integration, rev:2841
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/3296/
Executed test runs:
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build/4336
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=amd64,release=xenial+overlay,testname=qmluitests.sh/2590
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=amd64,release=zesty,testname=qmluitests.sh/2590
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-0-fetch/4364
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/4198
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/4198/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=zesty/4198
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=zesty/4198/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/4198
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/4198/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=zesty/4198
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=zesty/4198/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/4198
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/4198/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=zesty/4198
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=zesty/4198/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/3296/rebuild

review: Approve (continuous-integration)

Revision history for this message

Albert Astals Cid (aacid) wrote on 2017-03-13:

#

Text conflict in qml/Stage/ChildWindow.qml
1 conflicts encountered.

Was top-approved already.

review: Needs Fixing

lp://qastaging/~dandrader/unity8/availableDesktopArea updated on 2017-03-24

2868. By Launchpad Translations on behalf of unity-team on 2017-03-14

Launchpad automatic translations update.

2869. By Michael Terry on 2017-03-21

Support GNOME-style logout DBus API (making the Logout, Reboot, and Shutdown launcher commands work) (LP: #1673229)

Approved by: Albert Astals Cid, Unity8 CI Bot

2870. By Michael Terry on 2017-03-21

Don't lock the screen for guest users or users in the nopasswdlogin group. (LP: #1644237)

Approved by: Josh Arenson, Unity8 CI Bot

2871. By Pete Woods on 2017-03-21

Fix up indicators-client after refactoring (LP: #1672797)

Approved by: Albert Astals Cid, Unity8 CI Bot

2872. By Lukáš Tinkl on 2017-03-21

Reset always-show-osk gsetting on startup to default value (false atm)

Approved by: Albert Astals Cid, Unity8 CI Bot

2873. By Lukáš Tinkl on 2017-03-21

Fix the restored-to position with Miral due to the state changes being async (LP: #1669819)

Approved by: Daniel d'Andrada, Unity8 CI Bot

2874. By Lukáš Tinkl on 2017-03-21

Add a cursor name fallback mapping "grabbing" -> "closedhand" for Breeze

Approved by: Daniel d'Andrada, Unity8 CI Bot

2875. By Michael Zanetti on 2017-03-21

Add support for closing apps from the spread with "Q" (LP: #1670327)

Approved by: Albert Astals Cid, Unity8 CI Bot

2876. By Daniel d'Andrada on 2017-03-21

Really disable the window decoration when in staged mode

Instead of having it only fully translucent (but still catching input).
So that it doesn't eat mouse clicks and taps near the window's top edge (LP: #1670361)

Approved by: Lukáš Tinkl, Unity8 CI Bot

2877. By Lukáš Tinkl on 2017-03-21

Fix unsnapping a maximized window from the panel (LP: #1671721)

Approved by: Albert Astals Cid, Michał Sawicz, Unity8 CI Bot

2878. By Michael Zanetti on 2017-03-21

hide "private" launcher quicklist entries when the greeter is locked (LP: #1667649)

Approved by: Lukáš Tinkl

2879. By Michael Zanetti on 2017-03-21

add surface titles to launcher's quicklist (LP: #1661668)

Approved by: Lukáš Tinkl, Unity8 CI Bot

2880. By Daniel d'Andrada on 2017-03-21

Don't let clients resize their surfaces while in staged (phone/tablet) mode (LP: #1670390)

Approved by: Gerry Boland, Unity8 CI Bot

2881. By Daniel d'Andrada on 2017-03-21

TopLevelWindowModel: don't put hidden windows in the model

From the UI point of view, it's as if they didn't exist. (LP: #1665286)

Approved by: Albert Astals Cid

2882. By Lukáš Tinkl on 2017-03-21

Disable altDrag feature outside windowed mode

Approved by: Albert Astals Cid, Unity8 CI Bot

2883. By Michael Zanetti on 2017-03-21

properly reset the drawer state when cancelling a horizontal drag (LP: #1669536)

Approved by: Lukáš Tinkl, Unity8 CI Bot

2884. By Michael Zanetti on 2017-03-21

fix the focus moving correctly between launcher and drawer (LP: #1669880)

Approved by: Albert Astals Cid, Unity8 CI Bot

2885. By Michael Zanetti on 2017-03-21

unfocus the drawer's textfield when it is moved (LP: #1669839)

Approved by: Albert Astals Cid, Unity8 CI Bot

2886. By Albert Astals Cid on 2017-03-21

Signal aboutToShow (LP: #1664578)

Approved by: Lukáš Tinkl, Unity8 CI Bot

2887. By Albert Astals Cid on 2017-03-21

Support Panel top level items to be disabled

I needed to change the way MenuContent changes its position
from using the highlight to simply setting the contentX directly
since otherwise in some reset cases the position was wrong (LP: #1670694)

Approved by: Lukáš Tinkl, Unity8 CI Bot

2888. By Albert Astals Cid on 2017-03-21

Improve Launcher ←→ touch menu interaction

Needs to move the label from PanelItemRow to Panel because how clipping works in those items (and fixes some other problems too)

If launcher is locked visible:
     * Touch menus show shifted to the right to not overlap
     * Showing the app drawer closes the touch menus
     * Showing the touch menus closes the app drawer

If launcher is not locked visible:
* Showing the launcher closes the touch menus
* Showing the touch menus closes the launcher (LP: #1667620, #1671069)

Approved by: Lukáš Tinkl, Unity8 CI Bot

2889. By Albert Astals Cid on 2017-03-21

Fix real world submenus (e.g. kate) not getting their first item selected on open

MenuBar.qml: remove unused function
MenuPopup.qml: Select first item when one arrives if there's no currentItem instead of on completion
unitymenumodel.cpp: trick rowCount() to simulate "real world late" menus
tst_MenuPopup.qml: adapt to unitymenumodel.cpp changes (and make the Up test actually press Up and not Down) (LP: #1666859)

Approved by: Lukáš Tinkl, Unity8 CI Bot

2890. By CI Train Bot Account on 2017-03-21

Releasing 8.15+17.04.20170321-0ubuntu1

2891. By Launchpad Translations on behalf of unity-team on 2017-03-24

Launchpad automatic translations update.

2892. By Daniel d'Andrada on 2017-03-24

merge ../satelliteWindow/

2893. By Daniel d'Andrada on 2017-03-24

Tell qtmir/miral about the available desktop area

So that it can make correct window management decisions

Plus some refactorings:
- Make AvailableDesktopArea provide boundariesForWindowPlacement
- AvailableDesktopArea also replaces Stage.leftMargin and Panel.panelHeight in Stage.qml

Unity 8

Merge lp://qastaging/~dandrader/unity8/availableDesktopArea into lp://qastaging/unity8

Commit message

Description of the change

Unmerged revisions

Preview Diff

Subscribers