Code review comment for lp://qastaging/~dandrader/unity8/availableDesktopArea
Revision history for this message
| Daniel d'Andrada (dandrader) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
bbfa235
demo site
(Get the code!)
On 03/03/2017 08:42, Michael Zanetti wrote:
> Review: Needs Information
>
> I'm wondering why we still need those restrictions in Stage.qml at all, like the minimumY for WindowStateSaver, or the boundsItem on the MoveResizeArea. I would think now that miral knows the limits the qml code should not need to care about this any more at all?
Yeah, miral/qtmir might take care of it in the future. But they don't do
it right now.
> Perhaps miral is not quite there yet, I'm not sure.
It's not AFAICT.
> If we still need to provide those informations to the qml code, wouldn't it make sense to at least drop root.leftMargin etc and use the availableDeskto
Done. Also replaced usage of Panel.panelHeight with AvailableDeskto