Unity 8

Code review comment for lp://qastaging/~dandrader/unity8/noDecorationInStagedMode

  1. noDecorationInStagedMode
  2. Merge into trunk
Revision history for this message
Daniel d'Andrada (dandrader) wrote :

> opacity: root.hasDecoration ? Math.min(1, root.showDecoration) : 0
> visible: root.hasDecoration || opacity > 0
>
> I don't get the "visible" expression, why you need both?

Because when root.hasDecoration == true && opacity == 0 you will still want to capture the input events, as far as I understood it. Took the conservative approach.

But if you think that's no such use case I'm ok with making it a simple "visible: opacity > 0" as well.

« Back to merge proposal