Code review comment for lp://qastaging/~danilo/linaro-android-build-tools/no-seed

Revision history for this message
Данило Шеган (danilo) wrote :

Thanks for the review James: I want to keep static paths so it's more obvious what's going on (regular expressions are harder to update and always require you to stop and think to ensure they are doing the right thing). I even thought of defining a dict along the lines of

 rewrite_urls = {
   'git://git.linaro.org/': 'http://git.linaro.org/git-ro/',
   'git://git.linaro.org': 'http://git.linaro.org/git-ro',
   ...
 }

and using that instead. What do you think?

« Back to merge proposal