Code review comment for lp://qastaging/~danilo/linaro-android-build-tools/no-seed
Revision history for this message
| James Tunnicliffe (dooferlad) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
bbfa235
demo site
(Get the code!)
The dictionary approach is definitely better, but the trailing slash
causing duplications irritates me. You could rstrip('/') if we don't
need it (I assume we don't).
Agree about regexps - often the cause of write only code!