Code review comment for lp://qastaging/~danilo/simplestreams/custom-user-agent
Revision history for this message
| Данило Шеган (danilo) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
bbfa235
demo site
(Get the code!)
It would sure be easier, but it would still be more of a monkey-patching approach (i.e. modifying a value on the library code is kind-of bad).
For it to be cleaner, imho at least, we'd need an entirely different high level relationship between UrlReaders, MirrorReaders and ContentSources, which I think would be a significant refactoring, and highly likely to break some API backwards compatibility.
Thanks for the Python3 and all the other fixes: I'll take a look and then merge into my branch. Will ping tomorrow (close to EOD now) when I've looked over it.