Code review comment for lp://qastaging/~david4dev/dmedia/udisks

Revision history for this message
Jason Gerard DeRose (jderose) wrote :

Really nice work here, David!

You'll need to get the all unit tests working again, though. Most of the failures seem to be in the schema tests, the 2 files being:

  dmedia/schema.py
  dmedia/tests/test_schema.py

You can run just the schema tests like this:

  ./setup.py test --names=schema

And make sure to run all the tests at the end to, to make sure there aren't other failures. Run all the tests like this:

  ./setup.py test

But again, nice work! You jumped right in!

review: Needs Fixing

« Back to merge proposal