Code review comment for lp://qastaging/~david4dev/dmedia/udisks

Thanks!

I like the idea of the 'Adapter's because that then the tests should be deterministic.

The reason why _drive_id() is as it is is because the documentation ( http://hal.freedesktop.org/docs/udisks/Device.html#Device:DriveSerial ) says that DriveSerial and DriveWWN can be blank. I'm not sure how common this is in reality but this means I don't consider it safe to use only the DriveSerial.

As far as I know, these values are provided by the physical device but I'm not sure how these are handled and whether they would be the same on all platforms.