Code review comment for lp://qastaging/~deeptik/linaro-ci/fix-bug1013611

Revision history for this message
Paul Sokolovsky (pfalcon) wrote :

This is definitely looks good, and thanks for quick turnaround! For custom AMI BP, we with Stevan might need to do further tweaks, but having this will allow us to concentrate on our code first of all instead of spreading thin.

I also appreciate flexibility on Milo's side - it's true that our codebases lack on consistency side quite a bunch, but fixing that in adhoc manner oftentimes only complicates and procrastinates functional work. What I dream of is of us getting a blueprint "Clean up our codebases consistently", settle on extra rules we currently miss (like '_' vs '-' dichotomy) have a good swipe over all our projects, and they maintain them on that level.

review: Approve

« Back to merge proposal