Code review comment for lp://qastaging/~deeptik/linaro-ci/use_precise_hwpacks_for_kernel_ci

Revision history for this message
Deepti B. Kalakeri (deeptik) wrote :

On Thu, May 17, 2012 at 7:26 PM, Fathi Boudra <email address hidden>wrote:

> Review: Approve
>
> Approved. For further improvements:
> - it will be nice to have tests. It will make the review easier.
> - the code could be simplified if you use Jenkins API to get latest
> successful build.
>
>
Yes, I will add the tests sometime soon. I wanted this merge to go in ASAP
as I want to stop using oneiric.
Use latest successful build for.
I will merge the changes for now as you have approved. I will work further
if required and propose a new merge.

> --
>
> https://code.launchpad.net/~deeptik/linaro-ci/use_precise_hwpacks_for_kernel_ci/+merge/106143<https://code.launchpad.net/%7Edeeptik/linaro-ci/use_precise_hwpacks_for_kernel_ci/+merge/106143>
> You are the owner of
> lp:~deeptik/linaro-ci/use_precise_hwpacks_for_kernel_ci.
>

--
Thanks!!!
Deepti

« Back to merge proposal