Code review comment for lp://qastaging/~deeptik/linaro-image-tools/fix_bug_Bug816767

Revision history for this message
James Westby (james-w) wrote :

On Thu, 04 Aug 2011 16:58:57 -0000, Guilherme Salgado <email address hidden> wrote:
> > + line.startswith("hwpack-linaro")):
>
> I, for one, will surely not remember why we need this when I come back
> from holidays, and I'm sure others who didn't participate in the
> discussion where we realized it was necessary would be equally confused,
> so it's important to leave a comment here explaining why it's needed.

Also, the prefix added by hwpack create is "hwpack-". We just use
"linaro-" as a convention in the names of our hwpacks. This means that
the code above will only work for linaro people.

Thanks,

James

« Back to merge proposal