Code review comment for lp://qastaging/~desrt/notify-osd/GNOME_BACKGROUND_REPRESENTATIVE_COLORS
Revision history for this message
| David Barth (dbarth) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
bbfa235
demo site
(Get the code!)
Looks good, but can you add some tests?
What happens if the property does not exist? Is there a corresponding default mechanism to provide a sane value?
IMO, the test should verify that changing the background color results in the right color being received in the bubble.c function. Then, that border line values don't result in a crash and trigger a reasonable fallback value.