Code review comment for lp://qastaging/~didrocks/unity/fix-709179-709119

Revision history for this message
Jason Smith (jassmith) wrote :

Putting this into LauncherIcon is not the proper solution. Ideally the policy on dragging would be done in either Launcher or one of its sister classes.

Launcher is also aware of what button was pressed so thats an easy fix there. As for what icons can be dragged, I would suggest maybe in launcher model having a query for model->IconHasSisters (); which checks if there are other similar icons they can be dragged between. That might make more sense in the controller in the long run, or maybe the model needs to have the sorting algorithm in it, I am not sure yet.

review: Needs Fixing

« Back to merge proposal