Ubuntu One Control Panel

Merge lp://qastaging/~diegosarmentero/ubuntuone-control-panel/clickshare into lp://qastaging/ubuntuone-control-panel

  1. clickshare
  2. Merge into trunk
Proposed by Diego Sarmentero
Status: Merged
Approved by: dobey
Approved revision: 365
Merged at revision: 366
Proposed branch: lp://qastaging/~diegosarmentero/ubuntuone-control-panel/clickshare
Merge into: lp://qastaging/ubuntuone-control-panel
Diff against target: 70 lines (+36/-6)
2 files modified
ubuntuone/controlpanel/gui/qt/share_links.py (+18/-6)
ubuntuone/controlpanel/gui/qt/tests/test_share_links.py (+18/-0)
To merge this branch: bzr merge lp://qastaging/~diegosarmentero/ubuntuone-control-panel/clickshare
Reviewer Review Type Date Requested Status
Manuel de la Peña (community) Approve
Roberto Alsina (community) Approve
Review via email: mp+129199@code.qastaging.launchpad.net

Commit message

- Allow double click in the list items to see the detailed information (LP: #1065190).

To post a comment you must log in.
Revision history for this message
Roberto Alsina (ralsina) wrote :

code review only

review: Approve
Revision history for this message
Manuel de la Peña (mandel) wrote :

Tests pass on Q and code looks good. The only problem I see are the lint errors I get in Q, I'll approve because tarmac should block it if lint fails.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches