> Let's move all QLabel font sizes and color styles used in <span>s into one
> file with all styling constants.
> This is not blocking for this branch, so a new bug is being opened.
>
> ---
>
> Empty lines before the docstrings in class ActionsButtons and class
> EnhancedLineEdit.
>
> ----
>
> It's never a good idea to touch class variables in tests, because the state of
> the class variable is not resetted between tests. Please use regular instances
> for the fake objects instead every time you can, something like:
>
> class FakeDesktopService(object):
> """Fake QDesktopService."""
>
> def __init__(self):
> self.opened_url = None
>
> def openUrl(self, url):
> """Fake openUrl."""
> self.opened_url = url
>
> [...]
>
> def test_open_in_browser(self):
> """Test the execution of open_in_browser."""
> fake_desktop_service = FakeDesktopService()
> self.patch(QtGui, "QDesktopServices", fake_desktop_service)
> url = 'http://ubuntuone.com/asd123'
> self.ui.ui.line_copy_link.setText(url)
> self.ui._open_in_browser()
> expected = QtCore.QUrl(url)
> self.assertEqual(expected, fake_desktop_service.opened_url)
>
>
> And similarly in the two tests in ActionsButtonsTestCase.
>
> ----
>
> Please, fix the docstrings in:
> * test_move_to_main_list
> * test_get_public_files
> * test_copy
> Let's move all QLabel font sizes and color styles used in <span>s into one
> file with all styling constants.
> This is not blocking for this branch, so a new bug is being opened.
>
I've created a different bug for this: /bugs.launchpad .net/ubuntuone- control- panel/+ bug/1042228
https:/
> --- ice(object) : in_browser( self): service = FakeDesktopServ ice() service) ubuntuone. com/asd123' ui.line_ copy_link. setText( url) _open_in_ browser( ) l(expected, fake_desktop_ service. opened_ url) estCase. to_main_ list public_ files
>
> Empty lines before the docstrings in class ActionsButtons and class
> EnhancedLineEdit.
>
> ----
>
> It's never a good idea to touch class variables in tests, because the state of
> the class variable is not resetted between tests. Please use regular instances
> for the fake objects instead every time you can, something like:
>
> class FakeDesktopServ
> """Fake QDesktopService."""
>
> def __init__(self):
> self.opened_url = None
>
> def openUrl(self, url):
> """Fake openUrl."""
> self.opened_url = url
>
> [...]
>
> def test_open_
> """Test the execution of open_in_browser."""
> fake_desktop_
> self.patch(QtGui, "QDesktopServices", fake_desktop_
> url = 'http://
> self.ui.
> self.ui.
> expected = QtCore.QUrl(url)
> self.assertEqua
>
>
> And similarly in the two tests in ActionsButtonsT
>
> ----
>
> Please, fix the docstrings in:
> * test_move_
> * test_get_
> * test_copy
Fixed