Ubuntu One Control Panel

Code review comment for lp://qastaging/~diegosarmentero/ubuntuone-control-panel/tab-shares-functions

  1. tab-shares-functions
  2. Merge into trunk
Revision history for this message
Alejandro J. Cura (alecu) wrote :

There are no tests for keyPressEvent and moveEvent in SearchBox.
And also keyPressEvent could benefit from being refactored into smaller functions that are more easily testable.

----

The UI completely freezes for about 15 seconds when starting. The window manager even dims it, as it does with unresponsive windows.

This does not happen on trunk.

----

Besides the above two issues, all tests pass and the code looks good so far.

review: Needs Fixing

« Back to merge proposal