Code review comment for lp://qastaging/~diegosarmentero/ubuntuone-control-panel/tab-shares-functions

Revision history for this message
Alejandro J. Cura (alecu) wrote :

There are "ifs" in _key_down_pressed and _key_up_pressed, but there's only one test for each.
Please add more tests that check all possible combinations.

----

There's no need for this to be a dict:
    self.fake_desktop_service.data['url']

It should be just a variable:
    self.fake_desktop_service.opened_url

review: Needs Fixing

« Back to merge proposal