Code review comment for lp://qastaging/~djfroofy/txaws/modernize-924459

On Thu, Feb 9, 2012 at 10:23 PM, Drew Smathers <email address hidden> wrote:
> Drew Smathers has proposed merging lp:~djfroofy/txaws/modernize-924459 into lp:txaws.
>
> Requested reviews:
>  Duncan McGreggor (oubiwann)
> Related bugs:
>  Bug #924459 in txAWS: "Modernize txaws.client to use twisted.web.client.Agent"
>  https://bugs.launchpad.net/txaws/+bug/924459
>
> For more details, see:
> https://code.launchpad.net/~djfroofy/txaws/modernize-924459/+merge/92404
>
> Need to care how much we care about compatibility since: (1) This requires Twisted >= 11.1.0 so far as I know and (2) Some public members on BaseQuery no longer exist since they are not applicable when using Agent.

I've taken a quick look at the latest code tonight, and first glance
is a happy one :-)

I've branched the code on my laptop so that I can review it on the
plane tomorrow, run the unit tests, etc.

I hope to have more for you soon.