Code review comment for lp://qastaging/~djfroofy/txaws/newagent-767205

Revision history for this message
Drew Smathers (djfroofy) wrote :

> On Sat, Apr 14, 2012 at 12:28 PM, Drew Smathers
> <email address hidden> wrote:
> >>
> >> 1) split out the headers changes into a new branch, and attach it to bug
> >> #972432.
> >
> > #972432 must be a duplicate of #640098; the amz_headers argument has been
> merged already.  To summarize what this diff is adding: Support for plugging
> in Body Producers and Receivers in s3.client (this is made possible by:
> lp:~djfroofy/txaws/modernize-924459).
> >
> > There are actually no changes related to headers in this patch. Rather, I'm
> adding receiver_factory as __init__() argument to S3Client and body_producer
> as argument to regular S3 api calls.
> >
> > Cutting to the point, I think #972432 needs to be reviewed first.
>
> Do you mean bug #924459? (since bug #972432 is a duplicate of bug #640098 ...)
>
> >> 2) create a new bug for the body producer/receiver factory feature, split
> that
> >> code out, and attach it to there in its own branch.
> >
> > That was in the scope of #972432
>
> It looks like you mean bug #640098?

No, another typo, but I meant bug #924459. This has underlying support for the producer/receiver factory supports. This current ticket then just exposes that underlying support in s3 APIs.

« Back to merge proposal