Juju Charms Collection
ubuntu-ci-services-itself package

Merge lp://qastaging/~doanac/charms/precise/ubuntu-ci-services-itself/lander-cleanup into lp://qastaging/~canonical-ci-engineering/charms/precise/ubuntu-ci-services-itself/lander

  1. Precise Pangolin (12.04)
  2. lander-cleanup
  3. Merge into lander
Proposed by Andy Doan
Status: Merged
Approved by: Francis Ginther
Approved revision: 26
Merged at revision: 26
Proposed branch: lp://qastaging/~doanac/charms/precise/ubuntu-ci-services-itself/lander-cleanup
Merge into: lp://qastaging/~canonical-ci-engineering/charms/precise/ubuntu-ci-services-itself/lander
Diff against target: 88 lines (+71/-1)
2 files modified
templates/jobs/lander_master.xml (+4/-1)
templates/jobs/lander_ppa_free.xml (+67/-0)
To merge this branch: bzr merge lp://qastaging/~doanac/charms/precise/ubuntu-ci-services-itself/lander-cleanup
Reviewer Review Type Date Requested Status
Francis Ginther Approve
Andy Doan (community) Needs Resubmitting
Review via email: mp+201830@code.qastaging.launchpad.net

Commit message

Adds the ppa freeing job.

Description of the change

adds the ppa freeing job

To post a comment you must log in.
Revision history for this message
Francis Ginther (fginther) wrote :

The lander_ppa_free job should call lander_archiver to store it's log files:

=== modified file 'templates/jobs/lander_ppa_free.xml'
--- templates/jobs/lander_ppa_free.xml 2014-01-15 18:27:36 +0000
+++ templates/jobs/lander_ppa_free.xml 2014-01-16 22:03:29 +0000
@@ -46,6 +46,22 @@
       <artifacts>results/**</artifacts>
       <latestOnly>false</latestOnly>
     </hudson.tasks.ArtifactArchiver>
+ <hudson.plugins.parameterizedtrigger.BuildTrigger>
+ <configs>
+ <hudson.plugins.parameterizedtrigger.BuildTriggerConfig>
+ <configs>
+ <hudson.plugins.parameterizedtrigger.PredefinedBuildParameters>
+ <properties>request_id=$request_id
+source_job=$JOB_NAME
+source_url=$BUILD_URL</properties>
+ </hudson.plugins.parameterizedtrigger.PredefinedBuildParameters>
+ </configs>
+ <projects>lander_archiver</projects>
+ <condition>ALWAYS</condition>
+ <triggerWithNoParameters>false</triggerWithNoParameters>
+ </hudson.plugins.parameterizedtrigger.BuildTriggerConfig>
+ </configs>
+ </hudson.plugins.parameterizedtrigger.BuildTrigger>
   </publishers>
   <buildWrappers/>
 </project>

review: Needs Fixing
Revision history for this message
Francis Ginther (fginther) wrote :

Argh! That diff didn't come through very well. If you diff lander_ppa_assigner.xml and lander_ppa_free.xml, you'll see the xml chunk I added.

lp://qastaging/~doanac/charms/precise/ubuntu-ci-services-itself/lander-cleanup updated
26. By Andy Doan

as per fginther

Revision history for this message
Andy Doan (doanac) :
review: Needs Resubmitting
Revision history for this message
Francis Ginther (fginther) wrote :

+1

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches