Code review comment for lp://qastaging/~doanac/charms/precise/ubuntu-ci-services-itself/lander-cleanup

Revision history for this message
Francis Ginther (fginther) wrote :

The lander_ppa_free job should call lander_archiver to store it's log files:

=== modified file 'templates/jobs/lander_ppa_free.xml'
--- templates/jobs/lander_ppa_free.xml 2014-01-15 18:27:36 +0000
+++ templates/jobs/lander_ppa_free.xml 2014-01-16 22:03:29 +0000
@@ -46,6 +46,22 @@
       <artifacts>results/**</artifacts>
       <latestOnly>false</latestOnly>
     </hudson.tasks.ArtifactArchiver>
+ <hudson.plugins.parameterizedtrigger.BuildTrigger>
+ <configs>
+ <hudson.plugins.parameterizedtrigger.BuildTriggerConfig>
+ <configs>
+ <hudson.plugins.parameterizedtrigger.PredefinedBuildParameters>
+ <properties>request_id=$request_id
+source_job=$JOB_NAME
+source_url=$BUILD_URL</properties>
+ </hudson.plugins.parameterizedtrigger.PredefinedBuildParameters>
+ </configs>
+ <projects>lander_archiver</projects>
+ <condition>ALWAYS</condition>
+ <triggerWithNoParameters>false</triggerWithNoParameters>
+ </hudson.plugins.parameterizedtrigger.BuildTriggerConfig>
+ </configs>
+ </hudson.plugins.parameterizedtrigger.BuildTrigger>
   </publishers>
   <buildWrappers/>
 </project>

review: Needs Fixing

« Back to merge proposal