Merge lp://qastaging/~doanac/charms/precise/ubuntu-ci-services-itself/lander-image-builder-start into lp://qastaging/~canonical-ci-engineering/charms/precise/ubuntu-ci-services-itself/lander

Proposed by Andy Doan
Status: Merged
Approved by: Francis Ginther
Approved revision: 30
Merged at revision: 28
Proposed branch: lp://qastaging/~doanac/charms/precise/ubuntu-ci-services-itself/lander-image-builder-start
Merge into: lp://qastaging/~canonical-ci-engineering/charms/precise/ubuntu-ci-services-itself/lander
Diff against target: 43 lines (+19/-0)
1 file modified
templates/jobs/lander_master.xml (+19/-0)
To merge this branch: bzr merge lp://qastaging/~doanac/charms/precise/ubuntu-ci-services-itself/lander-image-builder-start
Reviewer Review Type Date Requested Status
Francis Ginther Approve
Review via email: mp+202759@code.qastaging.launchpad.net

Description of the change

This adds relations for the image builder and provides some scaffolding so it actually builds something.

To post a comment you must log in.
Revision history for this message
Paul Larson (pwlars) wrote :

I'm not too familiar with what lander_merge_parameters does, but if this is just supposed to be some sane values that should work as a quick test, that seems fine to me. Does it need to wait and see the end status for it? Does it need to do cleanup or anything? Every time you run this, you'll get a new copy of the image out in glance. I ask, because at least my personal account seems to have some limitations on the space, I got an error today that it was out of space.

Revision history for this message
Andy Doan (doanac) wrote :

On 01/27/2014 09:04 AM, Paul Larson wrote:
> I'm not too familiar with what lander_merge_parameters does, but if
> this is just supposed to be some sane values that should work as a
> quick test, that seems fine to me.

that was my idea. once the bsbuilder starts creating something real,
we'll be able to back out the hard-coded portion.

> Does it need to wait and see the
> end status for it?

yeah - we have to make the jenkins job listen to the progress-trigger so
it will know what to pass downstream to the next job.

> Does it need to do cleanup or anything? Every time
> you run this, you'll get a new copy of the image out in glance. I
> ask, because at least my personal account seems to have some
> limitations on the space, I got an error today that it was out of
> space.

i'm guessing we'll need to clean up these objects every so often during
development

30. By Andy Doan

add ticket-system information into params

Revision history for this message
Francis Ginther (fginther) wrote :

approve

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches