Code review comment for lp://qastaging/~doanac/charms/precise/ubuntu-ci-services-itself/lander-image-builder-start

Revision history for this message
Andy Doan (doanac) wrote :

On 01/27/2014 09:04 AM, Paul Larson wrote:
> I'm not too familiar with what lander_merge_parameters does, but if
> this is just supposed to be some sane values that should work as a
> quick test, that seems fine to me.

that was my idea. once the bsbuilder starts creating something real,
we'll be able to back out the hard-coded portion.

> Does it need to wait and see the
> end status for it?

yeah - we have to make the jenkins job listen to the progress-trigger so
it will know what to pass downstream to the next job.

> Does it need to do cleanup or anything? Every time
> you run this, you'll get a new copy of the image out in glance. I
> ask, because at least my personal account seems to have some
> limitations on the space, I got an error today that it was out of
> space.

i'm guessing we'll need to clean up these objects every so often during
development

« Back to merge proposal