Merge lp://qastaging/~doanac/phablet-tools/rndis into lp://qastaging/phablet-tools

PASSED: Continuous integration, rev:147
http://jenkins.qa.ubuntu.com/job/phablet-tools-ci/120/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/phablet-tools-saucy-amd64-ci/63
    SUCCESS: http://jenkins.qa.ubuntu.com/job/phablet-tools-saucy-armhf-ci/63
    SUCCESS: http://jenkins.qa.ubuntu.com/job/phablet-tools-saucy-i386-ci/63

Click here to trigger a rebuild:
http://s-jenkins:8080/job/phablet-tools-ci/120/rebuild

21 +# make sure we have proper permission when the device shows up as rndis
22 +SUBSYSTEM=="usb", ATTR{idVendor}=="18d1", RUN+="udev-acl --action=$env{ACTION} --device=$env{DEVNAME}"

can you add this to android-tools-adb ?

I can do it, but it needs to be removed from here (doesn't belong)

187 + adb $ADBOPTS push $tfile /var/lib/lxc/android/pre-start.sh
188 + adb $ADBOPTS shell chmod 755 /var/lib/lxc/android/pre-start.sh

failed to copy '/tmp/tmp.KSqkeJWenb' to '/var/lib/lxc/android/pre-start.sh': Read-only file system
chmod: changing permissions of '/var/lib/lxc/android/pre-start.sh': Read-only file system

This should be read from a flag in lxc-android-config

257 + 'phablet-network-bridge-addif',

This would be better installed in libexec or something, not a stopper though

> 21 +# make sure we have proper permission when the device shows up as
> rndis
> 22 +SUBSYSTEM=="usb", ATTR{idVendor}=="18d1", RUN+="udev-acl
> --action=$env{ACTION} --device=$env{DEVNAME}"
>
> can you add this to android-tools-adb ?
>
> I can do it, but it needs to be removed from here (doesn't belong)

This udev rule also only works on precise.

On 07/30/2013 12:52 PM, Sergio Schvezov wrote:
> Review: Needs Fixing
>
> 187 + adb $ADBOPTS push $tfile /var/lib/lxc/android/pre-start.sh
> 188 + adb $ADBOPTS shell chmod 755 /var/lib/lxc/android/pre-start.sh
>
> failed to copy '/tmp/tmp.KSqkeJWenb' to '/var/lib/lxc/android/pre-start.sh': Read-only file system
> chmod: changing permissions of '/var/lib/lxc/android/pre-start.sh': Read-only file system
>
> This should be read from a flag in lxc-android-config

Not sure I follow? If this is a read-only file, we're dead in the water.
Or are you saying check so that we can give a better error message?

> > 21 +# make sure we have proper permission when the device shows up as
> > rndis
> > 22 +SUBSYSTEM=="usb", ATTR{idVendor}=="18d1", RUN+="udev-acl
> > --action=$env{ACTION} --device=$env{DEVNAME}"
> >
> > can you add this to android-tools-adb ?
> >
> > I can do it, but it needs to be removed from here (doesn't belong)
>
> This udev rule also only works on precise.

Added https://code.launchpad.net/~sergiusens/ubuntu/saucy/android-tools/lax_udev/+merge/177661

> > 21 +# make sure we have proper permission when the device shows up as
> > rndis
> > 22 +SUBSYSTEM=="usb", ATTR{idVendor}=="18d1", RUN+="udev-acl
> > --action=$env{ACTION} --device=$env{DEVNAME}"
> >
> > can you add this to android-tools-adb ?
> >
> > I can do it, but it needs to be removed from here (doesn't belong)
>
> This udev rule also only works on precise.

It works on raring for me.

I think I've fixed all but the lxc-android-config/read-only thing you mentioned. One question:

do we need to update the packaging so that this now depends on a specific version of android-adb-tools so we don't get adb permission issues?

PASSED: Continuous integration, rev:149
http://jenkins.qa.ubuntu.com/job/phablet-tools-ci/122/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/phablet-tools-saucy-amd64-ci/65
    SUCCESS: http://jenkins.qa.ubuntu.com/job/phablet-tools-saucy-armhf-ci/65
    SUCCESS: http://jenkins.qa.ubuntu.com/job/phablet-tools-saucy-i386-ci/65

Click here to trigger a rebuild:
http://s-jenkins:8080/job/phablet-tools-ci/122/rebuild

On Tue, Jul 30, 2013 at 3:39 PM, Andy Doan <email address hidden> wrote:
> I think I've fixed all but the lxc-android-config/read-only thing you mentioned. One question:
>
> do we need to update the packaging so that this now depends on a specific version of android-adb-tools so we don't get adb permission issues?

The saucy versions use something like the MR I linked

-ACTION=="add|change", SUBSYSTEM=="usb", \
- ATTRS{idVendor}=="18d1", ATTRS{idProduct}=="d001|d002", \
- TAG+="uaccess"
+ACTION=="add|change", SUBSYSTEM=="usb", ATTRS{idVendor}=="18d1", TAG+="uaccess"

Tool version is the same on all environments as long as you have
ppa:phablet-team/tools added.

On 07/30/2013 02:43 PM, Sergio Schvezov wrote:
> On Tue, Jul 30, 2013 at 3:39 PM, Andy Doan <email address hidden> wrote:
>> I think I've fixed all but the lxc-android-config/read-only thing you mentioned. One question:
>>
>> do we need to update the packaging so that this now depends on a specific version of android-adb-tools so we don't get adb permission issues?
>
> The saucy versions use something like the MR I linked
>
> -ACTION=="add|change", SUBSYSTEM=="usb", \
> - ATTRS{idVendor}=="18d1", ATTRS{idProduct}=="d001|d002", \
> - TAG+="uaccess"
> +ACTION=="add|change", SUBSYSTEM=="usb", ATTRS{idVendor}=="18d1", TAG+="uaccess"
>
> Tool version is the same on all environments as long as you have
> ppa:phablet-team/tools added.
>

What I was trying to say is phablet-tools now requires a specific
version android-adb-tools in order for rndis to work. ie - we merged
this today, and you ran:

  apt-get update; apt-get install phablet-tools

you'd have an outdated version of android-adb-tools, right?