Code review comment for lp://qastaging/~doanac/phablet-tools/rndis

On 07/30/2013 02:43 PM, Sergio Schvezov wrote:
> On Tue, Jul 30, 2013 at 3:39 PM, Andy Doan <email address hidden> wrote:
>> I think I've fixed all but the lxc-android-config/read-only thing you mentioned. One question:
>>
>> do we need to update the packaging so that this now depends on a specific version of android-adb-tools so we don't get adb permission issues?
>
> The saucy versions use something like the MR I linked
>
> -ACTION=="add|change", SUBSYSTEM=="usb", \
> - ATTRS{idVendor}=="18d1", ATTRS{idProduct}=="d001|d002", \
> - TAG+="uaccess"
> +ACTION=="add|change", SUBSYSTEM=="usb", ATTRS{idVendor}=="18d1", TAG+="uaccess"
>
> Tool version is the same on all environments as long as you have
> ppa:phablet-team/tools added.
>

What I was trying to say is phablet-tools now requires a specific
version android-adb-tools in order for rndis to work. ie - we merged
this today, and you ran:

  apt-get update; apt-get install phablet-tools

you'd have an outdated version of android-adb-tools, right?