Code review comment for lp://qastaging/~doanac/phablet-tools/unlock_screen

Revision history for this message
Christopher Lee (veebers) wrote :

Andy,

I put this together today: https://code.launchpad.net/~veebers/unity8/adding_unlock_emulator/+merge/191328

The intention being that you consume these functions (namely unlock_unity and restart_unity_with_testability) in the unlock script (both here and any other script that does something similar i.e. Utah (and I think there is another CI one?).
This means that lines 117 - 181 aren't copied about in n-many scripts.

I'm not 100% certain this fits exactly Saviqs vision (i.e. done within the test app), I'll touch base with him in his morning and clarify then.

Let me know if you have any questions or suggestions.

Chris

« Back to merge proposal