Code review comment for lp://qastaging/~doanac/phablet-tools/unlock_screen

On Wed, Oct 16, 2013 at 4:24 PM, Andy Doan <email address hidden>wrote:

> On 10/15/2013 11:53 PM, Christopher Lee wrote:
>
> > The intention being that you consume these functions (namely
> unlock_unity and restart_unity_with_testability) in the unlock script (both
> here and any other script that does something similar i.e. Utah (and I
> think there is another CI one?).
> > This means that lines 117 - 181 aren't copied about in n-many scripts.
> >
> > I'm not 100% certain this fits exactly Saviqs vision (i.e. done within
> the test app), I'll touch base with him in his morning and clarify then.
> >
> > Let me know if you have any questions or suggestions.
>
> Sounds like there are three ways we could consume this code:
>
> 1) call these two functions from phablet-tools
> 2) modify all our autopilot tests to call this (or a common base class
> if possible).
>
> I'm guessing we don't have time to accomplish 2 before we release. So do
> we want to try 1 or just keep pushing for 2?
>

I had a similar response to this that I wiped earlier. The problem with 2
is, once we test on desktop and desktop is unity8 and you run locally you
are going to end up killing your own session. So first we have to make sure
this doesn't happen.