Code review comment for lp://qastaging/~doanac/ubuntu-test-cases/apt-get-update-rerun

Revision history for this message
Andy Doan (doanac) wrote :

On 02/26/2014 01:20 PM, Paul Larson wrote:
> I think we need a parameter for revision also, and if specified we also pass --revison {rev} in IMAGE_OPTS

I was thinking we could use the existing INSTALL_URL feature for that.
Is that okay, or should we try and add functionality for --rev (its not
currently supported in provision.sh)

> Was none of the xml in the rerun job something we could import from other template blocks? If not, fine. I was just wondering.

we don't really have template blocks for the smoke job anymore. maybe
its worth copying, but i thought it would be easier to prevent mistakes
this way (ie, not accidententally streaming live results to the dashboard).

> Also, I'm not sure we want to publish these anywhere on the dashboard do we?

The rerun template doesn't do any publishing.

« Back to merge proposal