Code review comment for lp://qastaging/~doanac/uci-engine/pub-pause

Revision history for this message
Francis Ginther (fginther) wrote :

I think this does what it's intended to do (and there are unit tests to match). The progress_retry() isn't being used anywhere, so this shouldn't regress anything.

Only question is if the name 'progress_retry' was meant to be named 'progress_pause'?

I'll approve as we really can't do much more with it until something else is in place to exercise it.

review: Approve

« Back to merge proposal