Merge lp://qastaging/~doanac/utah/probes-from-host into lp://qastaging/utah

Proposed by Andy Doan
Status: Merged
Merged at revision: 997
Proposed branch: lp://qastaging/~doanac/utah/probes-from-host
Merge into: lp://qastaging/utah
Diff against target: 54 lines (+11/-6)
2 files modified
client.py (+1/-0)
examples/run_utah_phablet.py (+10/-6)
To merge this branch: bzr merge lp://qastaging/~doanac/utah/probes-from-host
Reviewer Review Type Date Requested Status
Javier Collado (community) Approve
Max Brustkern (community) Approve
Review via email: mp+181698@code.qastaging.launchpad.net

Description of the change

To post a comment you must log in.
997. By Andy Doan

make the probes directory accessible via the environment

setup scripts and such (for example systemsettle) have the need
to store "attachment" type data. We can use the probes directory
for this by passing it as an environment variable.

we also need to update the from-host logic of run_utah_phablet.py
to specify this

Revision history for this message
Max Brustkern (nuclearbob) wrote :

This seems reasonable to me.

review: Approve
Revision history for this message
Javier Collado (javier.collado) wrote :

What is the UTAH_PROBE_DIR environment variable used for? I haven't seen it in any other place in the code.

Revision history for this message
Max Brustkern (nuclearbob) wrote :

> What is the UTAH_PROBE_DIR environment variable used for? I haven't seen it in
> any other place in the code.

It appears to be used by external scripts in other merges, such as this:
https://code.launchpad.net/~doanac/ubuntu-test-cases/system-settle-verbosity/+merge/181868

Revision history for this message
Javier Collado (javier.collado) wrote :

Ok, that makes sense then.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: