Merge lp://qastaging/~dobey/desktopcouch/more-fixes into lp://qastaging/desktopcouch

Proposed by dobey
Status: Merged
Approved by: Elliot Murphy
Approved revision: 13
Merged at revision: not available
Proposed branch: lp://qastaging/~dobey/desktopcouch/more-fixes
Merge into: lp://qastaging/desktopcouch
Diff against target: None lines
To merge this branch: bzr merge lp://qastaging/~dobey/desktopcouch/more-fixes
Reviewer Review Type Date Requested Status
Elliot Murphy (community) Approve
Guillermo Gonzalez Approve
Review via email: mp+9106@code.qastaging.launchpad.net

Commit message

[r=verterok, r=statik] Fix scripts to not use relative imports, Make the scripts executable, Fix the couchdb args list for subprocess.Popen

To post a comment you must log in.
Revision history for this message
Guillermo Gonzalez (verterok) :
review: Approve
Revision history for this message
Elliot Murphy (statik) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'desktopcouch/local_files.py'
--- desktopcouch/local_files.py 2009-07-20 16:16:58 +0000
+++ desktopcouch/local_files.py 2009-07-21 19:14:38 +0000
@@ -66,7 +66,7 @@
66 sys.exit(1)66 sys.exit(1)
6767
68def couch_chain_flag():68def couch_chain_flag():
69 process = subprocess.Popen(COUCH_EXE + ' -V', shell=True,69 process = subprocess.Popen([COUCH_EXE, '-V'], shell=True,
70 stdout=subprocess.PIPE)70 stdout=subprocess.PIPE)
71 line = process.stdout.read().split('\n')[0]71 line = process.stdout.read().split('\n')[0]
72 couchversion = line.split()[-1]72 couchversion = line.split()[-1]
@@ -78,7 +78,7 @@
78 return chain78 return chain
7979
8080
81# YOu will need to add -b or -k on the end of this81# You will need to add -b or -k on the end of this
82COUCH_EXEC_COMMAND = [COUCH_EXE, couch_chain_flag(), FILE_INI, '-p', FILE_PID,82COUCH_EXEC_COMMAND = [COUCH_EXE, couch_chain_flag(), FILE_INI, '-p', FILE_PID,
83 '-o', FILE_STDOUT, '-e', FILE_STDERR]83 '-o', FILE_STDOUT, '-e', FILE_STDERR]
8484
8585
=== modified file 'utilities/advertisePort.py'
--- utilities/advertisePort.py 2009-07-20 16:16:58 +0000
+++ utilities/advertisePort.py 2009-07-21 19:14:38 +0000
@@ -34,7 +34,7 @@
3434
35"""35"""
3636
37import local_files37from desktopcouch import local_files
3838
39import re39import re
40from errno import ENOENT40from errno import ENOENT
4141
=== modified file 'utilities/start_local_couchdb.py'
--- utilities/start_local_couchdb.py 2009-07-20 17:54:56 +0000
+++ utilities/start_local_couchdb.py 2009-07-21 19:14:38 +0000
@@ -33,7 +33,7 @@
3333
34from __future__ import with_statement34from __future__ import with_statement
35import os, subprocess, sys35import os, subprocess, sys
36import local_files36from desktopcouch import local_files
3737
38def dump_ini(data, filename):38def dump_ini(data, filename):
39 """Dump INI data with sorted sections and keywords"""39 """Dump INI data with sorted sections and keywords"""
4040
=== modified file 'utilities/stop_local_couchdb.py'
--- utilities/stop_local_couchdb.py 2009-07-09 19:44:43 +0000
+++ utilities/stop_local_couchdb.py 2009-07-21 19:14:38 +0000
@@ -20,7 +20,7 @@
20Stop local CouchDB server.20Stop local CouchDB server.
21"""21"""
22import subprocess, sys22import subprocess, sys
23import local_files23from desktopcouch import local_files
2424
25local_exec = local_files.COUCH_EXEC_COMMAND + ["-k"]25local_exec = local_files.COUCH_EXEC_COMMAND + ["-k"]
26try:26try:

Subscribers

People subscribed via source and target branches