Merge lp://qastaging/~dobey/ubuntuone-control-panel/fix-tests into lp://qastaging/ubuntuone-control-panel

Proposed by dobey
Status: Merged
Approved by: dobey
Approved revision: 399
Merged at revision: 399
Proposed branch: lp://qastaging/~dobey/ubuntuone-control-panel/fix-tests
Merge into: lp://qastaging/ubuntuone-control-panel
Diff against target: 123 lines (+26/-12)
4 files modified
ubuntuone/controlpanel/backend.py (+6/-3)
ubuntuone/controlpanel/tests/test_backend.py (+9/-3)
ubuntuone/controlpanel/tests/test_web_client.py (+9/-4)
ubuntuone/controlpanel/utils/tests/test_linux.py (+2/-2)
To merge this branch: bzr merge lp://qastaging/~dobey/ubuntuone-control-panel/fix-tests
Reviewer Review Type Date Requested Status
Mike McCracken (community) Approve
Roberto Alsina (community) Approve
Review via email: mp+150144@code.qastaging.launchpad.net

Commit message

Append query arguments to the URI, rather than passing in as parameters.
Fix new pyflakes warnings about variable redefinition in list comprehensions.

To post a comment you must log in.
Revision history for this message
Roberto Alsina (ralsina) :
review: Approve
Revision history for this message
Mike McCracken (mikemc) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: