Code review comment for lp://qastaging/~dooferlad/linaro-image-tools/fetch_image_cli

On 15 June 2011 18:22, Loïc Minier <email address hidden> wrote:
>  some comments from the other reviews apply   ;-)
>
> On Wed, Jun 15, 2011, James Tunnicliffe wrote:
>> +import linaro_image_tools.FetchImage as FetchImage
>> +import logging
>> +
>> +if __name__ == '__main__':
>
>  From there, I would only call into a
>    def main():
>  function as to help testing and code reuse

Noted. Will do.
<snip>
>> +    if config.args['platform'] == "snapshot":
>> +        config.args['release_or_snapshot'] = "snapshot"
>> +    else:
>> +        config.args['release_or_snapshot'] = "release"
>
>  Instead of release_or_snapshot, "archive"?  or "source"?

Release points to official Linaro releases, as currently hosted on
releases.linaro.org and shapshot the daily builds on
snapshots.linaro.org.

--
James Tunnicliffe