Merge lp://qastaging/~dpigott/lava-master-image-scripts/fix-master-prompt into lp://qastaging/lava-master-image-scripts

Proposed by Dave Pigott
Status: Merged
Approved by: Tyler Baker
Approved revision: 73
Merged at revision: 72
Proposed branch: lp://qastaging/~dpigott/lava-master-image-scripts/fix-master-prompt
Merge into: lp://qastaging/lava-master-image-scripts
Diff against target: 21 lines (+8/-3)
1 file modified
lava-create-master (+8/-3)
To merge this branch: bzr merge lp://qastaging/~dpigott/lava-master-image-scripts/fix-master-prompt
Reviewer Review Type Date Requested Status
Tyler Baker Approve
Zygmunt Krynicki (community) Approve
Review via email: mp+151432@code.qastaging.launchpad.net

Description of the change

The old way of changing the master boot prompt involved a sed which expected the hostname to be "root@linaro-nano", which it rarely is anymore, so I've done a less subtle "just write the files" approach.

To post a comment you must log in.
Revision history for this message
Zygmunt Krynicki (zyga) wrote :

Looks good, thanks

+1

review: Approve
Revision history for this message
Zygmunt Krynicki (zyga) wrote :

dave: would you not like to have a tarmac instance that merges some of lava's trees

I found that manually merging branches is so annoying once you don't have to.

Revision history for this message
Antonio Terceiro (terceiro) wrote :

On Mon, Mar 04, 2013 at 08:49:21AM -0000, Dave Pigott wrote:
> === modified file 'lava-create-master'
> --- lava-create-master 2013-01-29 12:30:39 +0000
> +++ lava-create-master 2013-03-04 08:48:22 +0000
> @@ -407,9 +407,9 @@
>
> # Update hostname to 'master'
> verbose " * Changing hostname to 'master'..."
> - sed -e 's/linaro-nano/master/' -i \
> - $MASTER_MNT/etc/hostname \
> - $MASTER_MNT/etc/hosts
> + echo "master" > /etc/hostname
> + echo "127.0.0.1 localhost" > /etc/hosts
> + echo "127.0.1.1 master" >> /etc/hosts

Should we care about this breaking eventual IPv6 support?

Nowadays /etc/hosts will also have the following lines by default:

::1 ip6-localhost ip6-loopback
fe00::0 ip6-localnet
ff00::0 ip6-mcastprefix
ff02::1 ip6-allnodes
ff02::2 ip6-allrouters

73. By Dave Pigott

Add ipv6 support

Revision history for this message
Tyler Baker (tyler-baker) wrote :

Looks good. Approved.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches