Code review comment for lp://qastaging/~dpigott/lava-master-image-scripts/fix-master-prompt

Revision history for this message
Antonio Terceiro (terceiro) wrote :

On Mon, Mar 04, 2013 at 08:49:21AM -0000, Dave Pigott wrote:
> === modified file 'lava-create-master'
> --- lava-create-master 2013-01-29 12:30:39 +0000
> +++ lava-create-master 2013-03-04 08:48:22 +0000
> @@ -407,9 +407,9 @@
>
> # Update hostname to 'master'
> verbose " * Changing hostname to 'master'..."
> - sed -e 's/linaro-nano/master/' -i \
> - $MASTER_MNT/etc/hostname \
> - $MASTER_MNT/etc/hosts
> + echo "master" > /etc/hostname
> + echo "127.0.0.1 localhost" > /etc/hosts
> + echo "127.0.1.1 master" >> /etc/hosts

Should we care about this breaking eventual IPv6 support?

Nowadays /etc/hosts will also have the following lines by default:

::1 ip6-localhost ip6-loopback
fe00::0 ip6-localnet
ff00::0 ip6-mcastprefix
ff02::1 ip6-allnodes
ff02::2 ip6-allrouters

« Back to merge proposal