Code review comment for lp://qastaging/~dpniel/ubuntu-autopilot-tests/gedit

Revision history for this message
Nicholas Skaggs (nskaggs) wrote :

Ok, I would do a few things here. This testcase looks like we can really test the app so much more with the new introspection bits. Good stuff!

Things we should do before pushing this:

-- Let's try and remove the basic sleeps

1) Remove this by checking for a new tab -- #Why not just check there is eventually a new tab???????
I see this logic in the code that could work
        documents = self.app.select_many('GeditTab')
        #note index starts at 0
        self.assertThat(documents[orginalNumDocuments].name, Contains(str(orginalNumDocuments + 1)))

2) The sleep(3) occurences. They occur waiting for subwindows like open/save/close dialogs. Can we check properly for these to appear? If not, we should think carefully about pushing anyway, if we want this to go to prod.

-- Let's comment out completely the tests that have no asserts, or add a simple assert. Every test needs a assert or there's no reason to even run it.

Things still needing work for later:

-- We should stop using keyboard shortcuts for everything and convert to mouse movements where it makes sense. Click the save button, don't use alt+s, etc

-- We should finish out some of the stubbed testcases; anything we've commented out above, along with expanding the testcases using objects since we can access them now.

« Back to merge proposal