Code review comment for lp://qastaging/~ed-leafe/nova/scheduler-multifilter

Revision history for this message
Thierry Carrez (ttx) wrote :

As far as I can tell, it's a very welcome refactoring that should definitely go into code, but I'm a bit torn on whether it should go in Diablo.

On one hand, it has regression potential and does not really solve a bug.

On another hand, I suspect it's better to have the new filters design in the release, rather than have to wait another release to build on the new one.

It's a bit of a product strategy decision, so I'm happy to defer to Vish on that one -- that branch wasn't part of the "features left to merge" in his recent email.

review: Needs Information (ffe)

« Back to merge proposal