OpenStack Compute (nova)

Code review comment for lp://qastaging/~ed-leafe/nova/scheduler-multifilter

  1. scheduler-multifilter
  2. Merge into trunk
Revision history for this message
Kevin L. Mitchell (klmitch) wrote :

On line 102—isn't that a relative import? We should probably be using only absolute imports…

On line 241 (unchanged from trunk)—do we still need the inner import here? I put the same import where you have the flags.DEFINE_string(), and everything worked fine; I think the circular dependency doesn't exist anymore.

review: Needs Fixing
Reply

« Back to merge proposal